Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPFS gateway support on Android #8257

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add IPFS gateway support on Android #8257

merged 1 commit into from
Mar 18, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 15, 2021

This adds support for IPFS via Gateway on Android.
It also adds a preference to be able to handle IPFS or disable it, it's defaulted to on.
If it is on and ipfs:// is navigated, we will show the IPFS interstitial page as we do on Desktop, bu the option for a local node will not be available.

Resolves brave/brave-browser#13683

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from a team as a code owner March 15, 2021 18:57
@bbondy bbondy self-assigned this Mar 15, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool ++

@@ -15,6 +15,8 @@
bool ProfileIOData::IsHandledProtocol(const std::string& scheme) {
if (scheme == kBraveUIScheme)
return true;
if (scheme == "ipfs")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe kIPFSScheme? and how about kIPNSScheme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, I forgot to update it after testing if it was the right change 👍

Copy link
Member Author

@bbondy bbondy Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to add ipns, I don't think I can use kIPFSScheme and kIPNSScheme here easily without patching in a dep to chrome/browser to components/ipfs. Maybe best to just keep it a string literal comparison?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbondy bbondy force-pushed the ipfs-android branch 6 times, most recently from 6fa35e7 to 586390d Compare March 17, 2021 17:07
@bbondy bbondy merged commit 534a1e1 into master Mar 18, 2021
@bbondy bbondy deleted the ipfs-android branch March 18, 2021 16:01
@bbondy bbondy added this to the 1.24.x - Nightly milestone Mar 18, 2021
yrliou added a commit that referenced this pull request Mar 18, 2021
This reverts commit 534a1e1, reversing
changes made to 103be2b.
bbondy added a commit that referenced this pull request Mar 18, 2021
Revert "Merge pull request #8257 from brave/ipfs-android"
@bbondy bbondy mentioned this pull request Mar 19, 2021
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IPFS gateway method first on Android
3 participants