-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IPFS gateway support on Android #8257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool ++
@@ -15,6 +15,8 @@ | |||
bool ProfileIOData::IsHandledProtocol(const std::string& scheme) { | |||
if (scheme == kBraveUIScheme) | |||
return true; | |||
if (scheme == "ipfs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe kIPFSScheme? and how about kIPNSScheme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, I forgot to update it after testing if it was the right change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to add ipns, I don't think I can use kIPFSScheme and kIPNSScheme here easily without patching in a dep to chrome/browser to components/ipfs. Maybe best to just keep it a string literal comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
6fa35e7
to
586390d
Compare
Revert "Merge pull request #8257 from brave/ipfs-android"
This adds support for IPFS via Gateway on Android.
It also adds a preference to be able to handle IPFS or disable it, it's defaulted to on.
If it is on and ipfs:// is navigated, we will show the IPFS interstitial page as we do on Desktop, bu the option for a local node will not be available.
Resolves brave/brave-browser#13683
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: