Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back application of legacy cosmetic filters #8126

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

antonok-edm
Copy link
Collaborator

Resolves brave/brave-browser#14458

Just quickly adds back actually applying the filters, which was removed in #6735 - will add migration to custom filters in brave://adblock in a follow up so we can keep the uplift to Release as minimal as possible.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to github.com
  2. Right click on GitHub's octocat logo (top left) -> Brave -> Block element via selector (it should be something like .mt-n1 > .Header-link > .octicon > path, or .mt-n1 > .Header-link > .octicon).
  3. Press OK. The logo icon should no longer be visible.
  4. Refresh the page.
  5. The logo icon should still not be visible.

@antonok-edm antonok-edm added the bug label Mar 4, 2021
@antonok-edm antonok-edm self-assigned this Mar 4, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failure to apply cosmetic filters added via right-click context menu
2 participants