-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop chrome-common-chrome_content_client_constants.cc.patch #8061
Conversation
All the relevant bots have passed already(*) so moving this to the review process:
Thanks! (*) The failure on the post-init bot is unrelated (being currently worked on separately) |
#ifndef BRAVE_CHROMIUM_SRC_CHROME_COMMON_CHROME_CONTENT_CLIENT_H_ | ||
#define BRAVE_CHROMIUM_SRC_CHROME_COMMON_CHROME_CONTENT_CLIENT_H_ | ||
|
||
#include "chrome/common/chrome_content_client.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This #include doesn't seem right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Removed now, thanks
This patch can be removed in favour of chromium_src overrides to redefine the values for the constants we're interested in. Resolves brave/brave-browser#14338
e06feaa
to
f2ea9a0
Compare
@simonhong Thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
This patch can be removed in favour of chromium_src overrides to
redefine the values for the constants we're interested in.
Resolves brave/brave-browser#14338
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See Test plan for #2342