Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 88.0.4324.152 to Chromium 88.0.4324.182 #7976

Merged
merged 3 commits into from
Feb 17, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 16, 2021

Fixes brave/brave-browser#14187
Related PR: brave/brave-browser#14190

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ - only major change seems to be the replacing of strip_chrome_binary action with custom strip_binary GN command 👍

@bsclifton bsclifton merged commit f25d284 into 1.21.x Feb 17, 2021
@bsclifton bsclifton deleted the 88.0.4324.182_1.21.x_77 branch February 17, 2021 06:34
mkarolin pushed a commit that referenced this pull request Feb 17, 2021
Upgrade from Chromium 88.0.4324.152 to Chromium 88.0.4324.182
@kjozwiak kjozwiak added this to the 1.21.x - Beta milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants