Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set default browser modal #7745

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Add set default browser modal #7745

merged 1 commit into from
Feb 1, 2021

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#12390

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 29, 2021
@deeppandya deeppandya added this to the 1.21.x - Nightly milestone Jan 29, 2021
@deeppandya deeppandya self-assigned this Jan 29, 2021
@deeppandya deeppandya force-pushed the add_set_default_browser_modal_android branch from 8e696d8 to bc4473b Compare January 29, 2021 07:48
SergeyZhukovsky
SergeyZhukovsky approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya
Add set default browser modal
78dae07 
Update behaviour for p3a modal
@deeppandya deeppandya force-pushed the add_set_default_browser_modal_android branch from bc4473b to 78dae07 Compare January 29, 2021 18:34
@deeppandya deeppandya merged commit bcc7dd6 into master Feb 1, 2021
@deeppandya deeppandya deleted the add_set_default_browser_modal_android branch February 1, 2021 03:36
@deeppandya deeppandya mentioned this pull request Feb 1, 2021
Merged
4 tasks
@srirambv
Copy link
Contributor

srirambv commented Feb 2, 2021

Verification passed on OnePlus 6T with Android 10 running 1.21.38 x64 nightly build

  • Verified default browser modal is shown after 5 days on a clean install
  • Verified selecting Set Brave as default brings up browser list to select Brave as default
  • Verified on upgrade default browser modal shows up as per spec

Dark Theme

Default browser modal Browser Selection
image image

Light Theme

Default browser modal Browser Selection
image image

@deeppandya deeppandya mentioned this pull request Feb 5, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.21.x - Release
Development

Successfully merging this pull request may close these issues.

Update the Default Browser Modal
3 participants
@deeppandya @srirambv @SergeyZhukovsky