Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check shield setting before blocking WebGL shader API #7026

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

pes10k
Copy link
Contributor

@pes10k pes10k commented Nov 3, 2020

Resolves brave/brave-browser#12310
Resolves brave/brave-browser#12366
Resolves brave/brave-browser#12448

Submitter Checklist:

Test Plan:

Go to Google Maps and see if you can scroll smoothly in and out with the scroll wheel or similar (in other words, make sure the issues in brave/brave-browser#12310 does not still happen)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pes10k pes10k requested a review from a team as a code owner November 3, 2020 02:15
@pes10k pes10k self-assigned this Nov 3, 2020
@pes10k pes10k force-pushed the check-fp-status-for-webgl-shader-api branch from c8c5e9d to 3816626 Compare November 3, 2020 04:40
@pilgrim-brave
Copy link
Contributor

CI failures are unrelated:

00:54:07      RewardsContributionBrowserTest.TipConnectedPublisherVerified (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:580)
00:54:07      RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:228)

so merging

@pilgrim-brave pilgrim-brave merged commit 1cbf7ca into master Nov 3, 2020
@pilgrim-brave pilgrim-brave deleted the check-fp-status-for-webgl-shader-api branch November 3, 2020 18:56
@pes10k pes10k added this to the 1.18.x - Nightly milestone Nov 4, 2020
brave-builds pushed a commit that referenced this pull request Nov 4, 2020
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.7 x64 using the following build:

Brave | 1.19.2 Chromium: 87.0.4280.49 (Official Build) nightly (x86_64)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | macOS Version 10.15.7 (Build 19H2)

Case #1 via brave/brave-browser#12366:

Visited https://webglreport.com and ensured that float/int precision: appears as highp/highp as per the following:

Screen Shot 2020-11-13 at 11 36 42 AM

Case #2 via brave/brave-browser#12448:

Visited https://netmap.vodafone.de/cokart-client/index.html?lang=de&app=cokart_4x and ensured the map was loading as per the following:

Screen Shot 2020-11-13 at 11 45 33 AM

Case #3 via brave/brave-browser#12310:

Ensured that zooming in/out via the mouse/trackpad wasn't as sensitive as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment