Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix #7026: Added Brave-Core Image Fetcher API #17400

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[iOS] - Fix #7026: Added Brave-Core Image Fetcher API #17400

merged 1 commit into from
Mar 1, 2023

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Adds Image Fetcher API to fetch SVGs, WebP and other formats for iOS
  • Refactor Favicon fetcher to use this instead, since it's the same code.

Resolves brave/brave-ios#7026

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 27, 2023
@Brandon-T Brandon-T added this to the 1.50.x - Nightly milestone Feb 27, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner February 27, 2023 18:31
@Brandon-T Brandon-T self-assigned this Feb 27, 2023
kylehickinson
kylehickinson requested changes Feb 27, 2023
View reviewed changes
ios/browser/api/web_image/image_downloader.mm Show resolved Hide resolved
ios/browser/api/web_image/web_image.mm Outdated
}

- (void)dealloc {
image_fetcher_.reset();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Shouldn't it reset automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary. I usually add it anyway. But fixed.

ios/browser/api/web_image/web_image.h Show resolved Hide resolved
ios/browser/api/web_image/web_image.mm Outdated Show resolved Hide resolved
@Brandon-T Brandon-T force-pushed the feature/ios-image-fetcher branch 2 times, most recently from f0e9179 to d6ae49c Compare February 28, 2023 19:08
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: d6ae49c0e5311df65af6778505a22a1f13a06211
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

4 similar comments
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: d6ae49c0e5311df65af6778505a22a1f13a06211
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: d6ae49c0e5311df65af6778505a22a1f13a06211
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: d6ae49c0e5311df65af6778505a22a1f13a06211
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: d6ae49c0e5311df65af6778505a22a1f13a06211
reason: unsigned
Please follow the handbook to configure commit signing
cc: @Brandon-T

@Brandon-T Brandon-T force-pushed the feature/ios-image-fetcher branch from d6ae49c to 93f4f87 Compare February 28, 2023 20:04
kylehickinson
kylehickinson reviewed Feb 28, 2023
View reviewed changes
ios/browser/api/favicon/favicon_driver.mm
Comment on lines +157 to +158
callback(net::NSURLWithGURL(icon_url),
icon.IsEmpty() ? nullptr : icon.ToUIImage());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK to pass nullptr here? Not sure where to follow to see if this callback is defined publicly anywhere and needs a nullable annotation. Is this the callback that eventually gets to web_image.h's method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's okay to be null on the iOS side :)

kylehickinson
kylehickinson approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about that nullptr but otherwise looks good

@Brandon-T Brandon-T merged commit 3b93e4c into master Mar 1, 2023
@Brandon-T Brandon-T deleted the feature/ios-image-fetcher branch March 1, 2023 15:09
This was referenced Mar 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

Remove SDWebImage SVG
2 participants
@Brandon-T @kylehickinson