Move Twitch rewards processing to Greaselion

[zenparsing]

Resolves brave/brave-browser#11466

Related PR brave/brave-site-specific-scripts#26

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint, npm run gn_check)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Requested a security/privacy review as needed.
• Added appropriate QA labels (QA/Yes or QA/No) to the associated issue
• Added appropriate release note labels (release-notes/include or release-notes/exclude) to the associated issue
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Desktop

Twitch user URL

• Clean profile
• Run browser
• Install Twitch Greaselion script
• Restart browser
• Open rewards panel to start rewards extension
• Visit a Twitch user URL (e.g., https://www.twitch.tv/laurenwags)
• Verify that correct publisher information appears in Rewards panel
• Verify that tipping works as expected
• Verify that verified checkmark appears in Rewards icon for verified publishers

Twitch video URL

• Clean profile
• Run browser
• Install Twitch Greaselion script
• Restart browser
• Open rewards panel to start rewards extension
• Visit a Twitch video URL (e.g., https://www.twitch.tv/videos/577831096)
• Verify that correct publisher information appears in Rewards panel
• Verify that tipping works as expected
• Verify that verified checkmark appears in Rewards icon for verified publishers

Excluded URLs

• Clean profile
• Run browser
• Install Twitch Greaselion script
• Restart browser
• Open rewards panel to start rewards extension
• Visit an excluded Twitch URL (e.g., https://www.twitch.tv/directory/game/Music)
• Verify that correct publisher information appears in Rewards panel (www.twitch.tv)
• Verify that tipping works as expected

History

• Navigate to various Twitch URLs in the same tab
• Verify that appropriate publisher information appears in the panel
• Verify that back/forward navigation updates the panel with correct publisher info

Tab Activation

• Navigate to various Twitch URLs in multiple tabs
• Verify that appropriate publisher information appears in the panel
• Verify that switching between tabs updates the panel with correct publisher info

Tipping non-Twitch Publishers

• Verify that tipping works as expected on non-Twitch publishers (we only made changes to Twitch and only on desktop)
• Verify that the panel looks as expected on non-Twitch publishers

Mobile

No changes were made to mobile platforms, so verify that Twitch navigation / tipping / Rewards panel continue to work as expected on those platforms.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[emerick]

I think this can just return true for desktop, now that all of the supported publishers use Greaselion.

[emerick]

@zenparsing You can probably remove the twitch.tv entry from the permissions key in the Rewards extension's manifest.

[emerick]

LGTM

[zenparsing]

CI failed on known test-browser issues, and passed on previous pushes.