Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Greaselion for Twitch publishers #11466

Closed
NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#7019
Closed

Use Greaselion for Twitch publishers #11466

NejcZdovc opened this issue Aug 27, 2020 · 1 comment · Fixed by brave/brave-core#7019
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.19.x - Release

Comments

@NejcZdovc
Copy link
Contributor

we should switch to GL for Twitch so that we can have faster turn around rate when something breaks.
@NejcZdovc NejcZdovc mentioned this issue Aug 27, 2020
Closed
15 tasks
@srirambv srirambv changed the title Use GreaseLion for Twitch publishers [Desktop] Use GreaseLion for Twitch publishers Sep 9, 2020
@NejcZdovc NejcZdovc assigned zenparsing and unassigned zenparsing Sep 30, 2020
@bsclifton bsclifton changed the title [Desktop] Use GreaseLion for Twitch publishers [Desktop] Use Greaselion for Twitch publishers Oct 26, 2020
@zenparsing zenparsing mentioned this issue Nov 2, 2020
Merged
33 tasks
@zenparsing zenparsing added this to the 1.19.x - Nightly milestone Nov 18, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 23, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.19.66 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)
General
  • Confirmed Greaselion script no longer needs to be installed manually, just need to confirm that Brave Local Data Updater is version >=1.0.27.
    image
  • Confirmed visiting non-verified publishers showed the generic twitch favicon in panel and AC table. Visited each of the below using a clean profile:
  • Confirmed visiting verified publishers showed the verified user favicon in the panel and AC table, Tips panel, Monthly contributions, Auto contributions, and Monthly statements. Visited each of the below using a clean profile:
    https://www.twitch.tv/laurenwags/
    https://www.twitch.tv/videos/226907251
    https://www.twitch.tv/redpwnie
Twitch user URL
  • Verified publisher:
    • Confirmed tip to https://www.twitch.tv/laurenwags showed on Tips panel of brave://rewards as expected
    • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
    • Confirmed able to adjust monthly contribution amount from panel
    • Confirmed able to remove monthly contribution from panel and brave://rewards page
    • Confirmed panel, 1 time tip, recurring tip banners, AC panel, Monthly statement all had verified checkmark
  • Non-verified publisher:
    • Confirmed tip to https://www.twitch.tv/jennrhim showed on pending table
    • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
    • Confirmed able to adjust monthly contribution amount from panel
    • Confirmed able to remove monthly contribution from panel and brave://rewards page

image
image
image
image
image
image
image
image
image


Brave | 1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2004 (Build 19041.685)
Twitch video URL
  • Verified publisher:
    • Confirmed tip to https://www.twitch.tv/videos/344762635 showed on Tips panel of brave://rewards as expected
    • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
    • Confirmed able to adjust monthly contribution amount from panel
    • Confirmed able to remove monthly contribution from panel and brave://rewards page
    • Confirmed panel, 1 time tip, and recurring tip banners all had verified checkmark
  • Non-verified publisher:
    • Confirmed tip to https://www.twitch.tv/jennrhim/videos showed on pending table
    • Confirmed recurring tip showed on Monthly Contributions panel of brave://rewards as expected
    • Confirmed able to adjust monthly contribution amount from panel
    • Confirmed able to remove monthly contribution from panel and brave://rewards page
      image
      image
      image
      image
      image
      image
Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env
Confirmed example in test plan:
image
image
image

Spot checked other excluded URLs:
image
image
image

History
  • Navigate to various Twitch URLs in the same tab and ensured appropriate publisher information appears in the panel
  • Verified the back/forward navigation and ensured correct publisher info is shown in the panel

https://www.twitch.tv/redpwnie
https://www.twitch.tv/laurenwags
https://www.twitch.tv/videos/344762635
https://www.twitch.tv/jennrhim/videos

image
image
image
image

image

Tab Activation
Tipping non-Twitch Publishers
  • Verify that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
  • Verified that one-time tips can be sent to verified non-Twitch publishers
  • Verified that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel
  • Verified that non-Twitch publishers are added to AC table

image
image
image
image

------------------------------

Verification in progress with

Brave	1.19.75 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)
General
  • Confirmed component version:
GL Component Screen Shot 2021-01-05 at 9 45 01 AM Screen Shot 2021-01-05 at 9 43 53 AM
  • Confirmed twitch icon for verified publishers:
Screen Shot 2021-01-05 at 9 44 23 AM
  • Confirmed custom icon (when configured) for verified publishers:
Screen Shot 2021-01-05 at 9 44 40 AM Screen Shot 2021-01-05 at 9 46 58 AM
Twitch user URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (twitch.tv/laurenwags)
Confirmed verified checkmark appears on BAT logo for verified pub.
Screen Shot 2021-01-05 at 10 05 56 AM

Confirmed one time and monthly tips worked as expected for verified pub.
Screen Shot 2021-01-05 at 10 06 08 AM
Screen Shot 2021-01-05 at 10 06 24 AM
Screen Shot 2021-01-05 at 10 06 51 AM

Confirmed correct publisher info in Rewards panel for non-verified pub (twitch.tv/chess).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.
Screen Shot 2021-01-05 at 10 08 57 AM

Confirmed one time tip goes to pending list for non-verified pub.
Screen Shot 2021-01-05 at 10 09 06 AM
Screen Shot 2021-01-05 at 10 09 18 AM

Twitch video URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (https://www.twitch.tv/videos/344762635).
Confirmed verified checkmark appears on BAT logo for verified pub.
Screen Shot 2021-01-05 at 10 45 43 AM

Confirmed one time and monthly tips worked as expected for verified pub.
Screen Shot 2021-01-05 at 10 45 53 AM
Screen Shot 2021-01-05 at 10 46 05 AM
Screen Shot 2021-01-05 at 10 46 45 AM

Confirmed correct publisher info in Rewards panel for non-verified pub (https://www.twitch.tv/videos/226907251).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.
Screen Shot 2021-01-05 at 10 48 55 AM

Confirmed one time tip goes to pending list for non-verified pub.
Screen Shot 2021-01-05 at 10 49 06 AM
Screen Shot 2021-01-05 at 10 49 18 AM

Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env

Confirmed example in test plan:
Screen Shot 2021-01-05 at 1 52 07 PM
Screen Shot 2021-01-05 at 1 52 16 PM
Screen Shot 2021-01-05 at 1 52 32 PM

Spot checked other excluded URLs:
Screen Shot 2021-01-05 at 1 55 54 PM
Screen Shot 2021-01-05 at 1 56 20 PM
Screen Shot 2021-01-05 at 3 08 28 PM

Brave	1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)
History

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the same tab and using back/forward navigation buttons that the expected publisher information was shown

Tab Activation

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the multiple tabs and switching between the tabs that the expected publisher information was shown.

Tipping non-Twitch Publishers

Verified test plan from brave/brave-core#7019

Confirmed that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
Confirmed that one-time tips can be sent to verified non-Twitch publishers
Confirmed that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel

Pending List One Time Tip Monthly Tip
Screen Shot 2021-01-07 at 9 47 53 AM Screen Shot 2021-01-07 at 9 47 41 AM Screen Shot 2021-01-07 at 9 47 33 AM
General
  • Confirmed component version:

image

Twitch user URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub (twitch.tv/laurenwags)
Confirmed verified checkmark appears on BAT logo for verified pub.
image

Confirmed one time and monthly tips worked as expected for verified pub.
image

Confirmed correct publisher info in Rewards panel for non-verified pub (twitch.tv/chess).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.
image

Confirmed one time tip goes to pending list for non-verified pub.
image
image
image
image

Twitch video URL

Verified test plan from brave/brave-core#7019 using staging env

Confirmed correct publisher info in Rewards panel for verified pub https://www.twitch.tv/videos/344762635
Confirmed verified checkmark appears on BAT logo for verified pub.
image

Confirmed one time and monthly tips worked as expected for verified pub.
image
image
image

Confirmed correct publisher info in Rewards panel for non-verified pub (https://www.twitch.tv/videos/226907251).
Confirmed no verified checkmark appears on BAT logo for non-verified pub.
image

Confirmed one time tip goes to pending list for non-verified pub.
image
image

Excluded URLs

Verified test plan from brave/brave-core#7019 using staging env

Confirmed example in test plan:
image

Spot checked other excluded URLs:
image
image

History

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the same tab and using back/forward navigation buttons that the expected publisher information was shown

Tab Activation

Verified test plan from brave/brave-core#7019

Confirmed after navigating to multiple twitch URLs in the multiple tabs and switching between the tabs that the expected publisher information was shown.

Tipping non-Twitch Publishers

Verified test plan from brave/brave-core#7019

Confirmed that one-time tips for unverified non-Twitch publishers are going into the pending contribution table
Confirmed that one-time tips can be sent to verified non-Twitch publishers
Confirmed that recurring tips for non-Twitch publishers (verified +unverified) are listed in the Monthly Contribution panel

Pending List One Time Tip Monthly Tip
image image

@rebron rebron changed the title [Desktop] Use Greaselion for Twitch publishers Use Greaselion for Twitch publishers Jan 4, 2021
@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

Move Twitch rewards processing to Greaselion brave/brave-core
5 participants
@zenparsing @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya