Adding Crypto.com widget to the NTP [1.16] #6828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NTP Update #2
Cleans up widget menu position/padding
|
Restarted MacOS due to unrelated failure |
kjozwiak
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Uplift into 1.16.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6705 (comment) & #6766 (comment). However, @srirambv found the following issues that we'll need to get resolved in 1.16.x. Once they're all fixed, @ryanml will create another uplift PR for 1.16.x.
- [Widget] Missing asset icon for CRO brave-browser#12094 - Still opened, waiting on assets from Crypto.com
- [Widget] Unnecessary scroll bar on asset details view brave-browser#12089 - Still opened
- [Widget] Cards not properly aligned under more cards in dashboard settings brave-browser#12093 - Merged into Nightly (
1.17x.) - [Widget] Add crypto widget looks faded in dashboard brave-browser#12092 - Merged into Nightly (
1.17x.) - [Widget] Supported pairs options don't show up when network is back brave-browser#12091 - Merged into Nightly (
1.17x.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of: #6705, #6766
Resolves: brave/brave-browser#12074, brave/brave-browser#9247
Approved, please ensure that before merging:
After you merge: