Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crypto.com widget to the NTP #12074

Closed
ryanml opened this issue Oct 11, 2020 · 1 comment
Closed

Add Crypto.com widget to the NTP #12074

ryanml opened this issue Oct 11, 2020 · 1 comment

Comments

@ryanml
Copy link
Contributor

ryanml commented Oct 11, 2020

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux / Windows 10 OS Version 1809 (Build 17763.1518) / macOS Version 10.15.7 (Build 19H2)
Verified Crypto.com widget is added to the stack by default on a clean profile
Linux Windows macOS
Verified selecting `Crypto.com` widget shows opt-in state with BTC as default listed currency
Linux Windows macOS
Verified clicking on show price in opt-in view shows the current market price and 24hr % change for BTC
Linux Windows macOS
Verified clicking on `Buy` button or `Buy Bitcoin` button in opt-in view opens up the landing page in a new tab
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
Verified clicking on `View Crypto.com Markets` open up the top movers (assets view)
Linux Windows macOS
Verified clicking on any of the listed tokens, opens up individual tokens 7d graph and lists 24hr volume in USD and supported trading pairs for individual asset
Linux Windows macOS
Verified clicking on any of the trading pairs on any of the asset opens a landing page in a new tab and loads
https://auth.crypto.com/users/sign_up?utm_campaign=Brave%3AWW-en%3ATrading-Widget_MVP_InitialWidgetState_BuyButton_Top&utm_content=MVP_InitialWidgetState_BuyButton_Top&utm_medium=Trading+Widget&utm_source=Brave
Verified `Crypto.com` widget can be disabled via either of the following ways
Linux (Widget menu) Windows (Widget menu) macOS (Widget menu)
Linux (Add cards in dashboard) Windows (Add cards in dashboard) macOS (Add cards in dashboard)
Linux (New Tab page settings) Windows (New Tab page settings) macOS (New Tab page settings)
  • Verified widget retains the state between disable and enabled

    • If the widget is in opt-in state and then disabled, re-adding the widget still shows it in opt-in state
    • If the widget is already in the market view (tokens), disable and re-adding the widget doesn't go back to opt-in state but retains the market view
  • Verified the price value is updated every 30 secs because of which value will always be a little off compared to the market value shown on website
    image

Verified when the network is disconnected/disrupted, balance and price chart is removed. Re-connecting to network updates the trade value and chart after 30sec
Linux Windows macOS
  • Verified upgrading from an older build in supported regions widget is automatically added to the stack
Verified for unsupported regions, there is no `Crypto.com` widget shown on a clean install or on upgrade
Linux (Japanese) Windows (Nepali) macOS (Vietnamese)
Linux (Add cards in dashboard) Windows (Add cards in dashboard) macOS (Add cards in dashboard)
Linux (New Tab page settings) Windows (New Tab page settings) macOS (New Tab page settings)
  • Verified widget is English only even for non-EN locales
  • Verified widget is not available on Private windows/Guest/Tor windows
  • Verified clearing data doesn't reset widget state to opt-in state

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment