Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes estimated earnings and Ad notifications are not updating for users - 1.15.x #6770

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 5, 2020

Uplift of #6758
Resolves brave/brave-browser#11952

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Fixes estimated earnings and Ad notifications are not updating for users
@tmancey tmancey requested a review from a team October 5, 2020 15:41
@tmancey tmancey self-assigned this Oct 5, 2020
@kjozwiak kjozwiak added this to the 1.15.x - Release #3 milestone Oct 8, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.15.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6758 (comment). The cases were split into 1/3 and checked on macOS, Win x64 and Linux. Because this PR is so large and has a lot of cases, Linux will be skipped on 1.15.x and all the cases will be checked on macOS & Win x64.

@kjozwiak kjozwiak merged commit 246fefa into 1.15.x Oct 13, 2020
@kjozwiak kjozwiak deleted the issues/11952-1.15.x branch October 13, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants