Fixes estimated earnings and ad notifications are not updating for users #6758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
force-pushed
the
issues/11952
branch
4 times, most recently
from
00d25c9 to
a6fcb01
Compare
emerick
approved these changes
Oct 2, 2020
...at-native-ads/src/bat/ads/internal/server/refill_unblinded_tokens/refill_unblinded_tokens.cc
Show resolved
Hide resolved
kylehickinson
approved these changes
Oct 2, 2020
NejcZdovc
approved these changes
Oct 2, 2020
yachtcaptain23
approved these changes
Oct 2, 2020
tmancey
force-pushed
the
issues/11952
branch
2 times, most recently
from
1757aaa to
9057d56
Compare
… has been processed
…log has been processed
tmancey
force-pushed
the
issues/11952
branch
2 times, most recently
from
4b5ab90 to
ac60287
Compare
tmancey
added a commit
that referenced
this pull request
Oct 5, 2020
Fixes estimated earnings and Ad notifications are not updating for users
tmancey
added a commit
that referenced
this pull request
Oct 5, 2020
Fixes estimated earnings and ad notifications are not updating for users
This was referenced Oct 5, 2020
|
Using the below build: Verified the following scenarios on Nightly: See below for details Confirm unblinded tokens are refilled if we have less than 10 unblinded tokens when triggering an event to server an ad notification
Confirm failed confirmations are retried after attempting to download the catalogViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation: Closed browser, disabled rewrite rule, relaunched browser. Confirmed after catalog was downloaded, the failed confirmations for retry were scheduled: Confirmed at expected time ( Confirm failed confirmations are retried when an unblinded token redemption failsViewed an ad, enabled Charles re-write rule to make confirmation fail, then dismissed the ad to create a failed confirmation: Disabled Charles rewrite rule and waited until the time mentioned in the logs ( Confirm unblinded tokens are refilled to 50 if we are below the threshold after attempting to download the catalogEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Enable Charles rewrite rule outlined in https://github.com/brave/internal/issues/731. Use +1/-1 on Ad history to use tokens so that you have less than 20 left: Close browser. Disable Charles rewrite rule. Relaunch browser. Confirm after catalog is downloaded that tokens are refilled successfully: Confirm unblinded tokens are refilled to 50 if we are below the threshold after redeeming an unblinded tokenEnable Rewards, wait until everything is complete (catalog download, tokens fetched, etc). View an ad, dismiss ad. Use +1/-1 on Ad history to use tokens just until you have 20 left: Use the other (+1 or -1) button to get to 19 and confirm that tokens are refilled successfully: Verification passed on
Confirm ad rewards are reconciled upon browser launch
Confirm ad rewards are reconciled after restoring a wallet
Confirm ad rewards are reconciled after redeeming unblinded payment tokens
Confirm ad rewards are reconciled after claiming an ad promotion
Verification passed on
Verified catalog is downloaded upon browser launchVerified Confirm catalog is downloaded every ~2 hoursVerified catalog is scheduled to be downloaded Verified catalog is downloaded at that hour: Verified catalog download is not started if currently retrying a previously failed downloadVerified Confirm unblinded payment tokens are redeemed ~24 hoursVerified unblinded payment tokens redemption is not started if currently retrying a previously failed downloadVerified |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11952
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
404 NOT FOUNDforPOST /v1/confirmation/token/{payment_id}endpoint)Reviewer Checklist:
After-merge Checklist:
changes has landed on.