Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes response from logs (uplift to 1.12.x) #6444

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Removes response from logs (uplift to 1.12.x) #6444

merged 1 commit into from
Aug 19, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 18, 2020 •
edited by kjozwiak
Loading

Uplift of #6426
Resolves brave/brave-browser#11255

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 1.12.x - Release Hotfix 1 milestone Aug 18, 2020
@NejcZdovc NejcZdovc requested a review from a team August 18, 2020 19:32
@NejcZdovc NejcZdovc self-assigned this Aug 18, 2020
@kjozwiak
Copy link
Member

Restarted on all the platforms using Build with parameters as they all failed due to the following:

hudson.remoting.ProxyException: groovy.lang.MissingPropertyException: No such property: NODE_LABEL for class: WorkflowScript

kjozwiak
kjozwiak approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6426 (comment).

@kjozwiak kjozwiak merged commit 891ad7d into 1.12.x Aug 19, 2020
@kjozwiak kjozwiak deleted the logs-response-1.12 branch August 19, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @kjozwiak