Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] prune log responses #11255

Closed
diracdeltas opened this issue Aug 17, 2020 · 6 comments · Fixed by brave/brave-core#6426
Closed

[Security] prune log responses #11255

diracdeltas opened this issue Aug 17, 2020 · 6 comments · Fixed by brave/brave-core#6426
Assignees
Labels

Comments

@diracdeltas
Copy link
Member

see https://github.com/brave/internal/issues/712#issuecomment-674643946 for details.

@diracdeltas diracdeltas added security sec-high priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop labels Aug 17, 2020
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 17, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 17, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 17, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 18, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 18, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 19, 2020

Verification PASSED on Mint 19.1 x64 using the following build:

Brave | 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
--- | ---
Revision | c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS | Linux

Verification passed on


Brave | 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
-- | --
Revision | c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave | 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
-- | --
Revision | c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS | macOS Version 10.14.6 (Build 18G3020)

@bbondy
Copy link
Member

bbondy commented Aug 26, 2020

@NejcZdovc should this be marked OS/Android?

@diracdeltas
Copy link
Member Author

@bbondy this should get fixed on android as well

@bbondy
Copy link
Member

bbondy commented Aug 26, 2020

Understood, but wanted to see if this issue tracked the fix for Android too, or if there was a different issue for Android. If there is another issue, pls link to it. Noting too that pod leads should uplift to release channel if a hotfix is needed and ping Kamil and team to do a hotfix.

@diracdeltas
Copy link
Member Author

Got it. There is no separate issue for Android.

@diracdeltas diracdeltas added the OS/Android Fixes related to Android browser functionality label Aug 26, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 26, 2020

Quickly talked to @diracdeltas and we'll be releasing the above in 1.13.x. I'll create a duplicate issue in 1.13.x so @srirambv can verify that the above has also been fixed. Should already be in 1.13.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants