bug: Ensure usage pings sent on browser upgrade (uplift to 1.9.x) #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurenWags
approved these changes
May 27, 2020
There was a problem hiding this comment.
@keur @bsclifton uplift into 1.9.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issues are moved into the correct milestone.
|
CI looks good! Only one known issue here with macOS: This is captured with https://github.com/brave/brave-browser/issues/6515h and isn't a blocker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift of #5635
Fixes brave/brave-browser#9921
Approved, please ensure that before merging:
After you merge: