Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats ping not being sent for users who updated to 1.9.72 #9921

Closed
kkuehlz opened this issue May 23, 2020 · 3 comments · Fixed by brave/brave-core#5635
Closed

Stats ping not being sent for users who updated to 1.9.72 #9921

kkuehlz opened this issue May 23, 2020 · 3 comments · Fixed by brave/brave-core#5635
Assignees
@kkuehlz
Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.9.x - Release H...

Comments

@kkuehlz
Copy link
Contributor

kkuehlz commented May 23, 2020

Description

Usage pings being dropped on 1.9.72

Steps to Reproduce

  1. Have a release version of Brave < 1.9.72
  2. Upgrade to 1.9.72
  3. See that usage pings are not sent when the browser starts

Actual result:

Changing of referral initialization local preference means that, for migrated users, usage pings are not being sent to referral server.

Expected result:

All users send usage pings

Reproduces how often:

Always

Miscellaneous Information:

Hotfix in nightly brave/brave-core#5635
@kkuehlz
Copy link
Contributor Author

kkuehlz commented May 23, 2020

Test Plan

  1. Have a release version of Brave < 1.9.72 and hotfixed version > 1.9.72
  2. Start browser version < 1.9.72.
  3. Ensure that browser has initialized with the referral server (promo code file deleted, should have download id in brave://local-state)
  4. Simulate an upgrade by launching hotfixed version > 1.9.72
  5. View network traffic with Wireshark, Charles, etc
  6. See that usage ping is sent out to laptop-updates
  7. Test this with a referral code and without a referral code

@bsclifton bsclifton added priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/Yes release-notes/include labels May 23, 2020
@bsclifton bsclifton added this to the 1.11.x - Nightly milestone May 23, 2020
@kkuehlz kkuehlz mentioned this issue May 23, 2020
Merged
32 tasks
@bsclifton
Copy link
Member

Fixed with brave/brave-core#5635

This was referenced May 23, 2020
Merged
Merged
This was referenced May 27, 2020
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 28, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

Scenario 1 (Upgrade case w/ non-default promo code):

  1. Launch Fiddler.
  2. Installed 1.8.96
  3. Launch 1.8.96 using promoCode KAM253
  4. Confirmed I saw ping in Fiddler:

1 8 96 KAM253

  1. Close Brave. Update to 1.9.72.
  2. Move computer clock ahead one day.
  3. Launch Brave using 1.9.72.
  4. Confirmed I could reproduce the issue of not seeing a ping like above image.
  5. Close Brave. Update to 1.9.76
  6. Move computer clock ahead one day.
  7. Launch Brave using 1.9.76.
  8. Confirmed I saw ping in Fiddler:

1 9 76 KAM253

Scenario 2 (Upgrade case with default promo code):

  1. Launch Fiddler.
  2. Installed 1.8.96
  3. Launch 1.8.96 without a promoCode (uses default BRV001)
  4. Confirmed I saw ping in Fiddler.

1 8 96 BRV001

  1. Close Brave. Update to 1.9.72.
  2. Move computer clock ahead one day.
  3. Launch Brave using 1.9.72
  4. Confirmed I could reproduce the issue of not seeing a ping like above image.
  5. Close Brave. Update to 1.9.76.
  6. Move computer clock ahead one day.
  7. Launch brave using 1.9.76.
  8. Confirmed I saw ping in Fiddler.

1 9 76 BRV001

Scenario 3 (Clean install of 1.9.76):

  1. Launch Fiddler.
  2. Installed 1.9.76.
  3. Launch 1.9.76 without a promoCode (uses default BRV001).
  4. Confirmed I saw ping in Fiddler.

1 9 76 clean

  1. Close Brave.
  2. Move computer clock ahead one day.
  3. Launch again.
  4. Confirmed I saw ping in Fiddler.

1 9 76 clean day 2

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified the test plan below.

Click to show full test plan

Scenario 1 - Upgrade 1.8.96 -> 1.9.72 -> 1.9.76

  1. Installed 1.8.96
  2. Verified ping is sent
    image
  3. Move the clock 24h forward
  4. Update to 1.9.72
  5. Verified ping is not sent
  6. Update to 1.9.76
  7. Verified ping is sent
    image
  8. Move the clock 24h forward
  9. Verified ping is sent
    image

Scenario 2 - Upgrade 1.9.72 -> 1.9.76

  1. Installed 1.9.72
  2. Verified ping is sent
    image
  3. Move the clock 24h forward
  4. Verified ping is sent
  5. Update to 1.9.76
  6. Move the clock 24h forward
  7. Verified ping is sent
    image

Scenario 3 - Clean install 1.9.76

  1. Clean install to 1.9.76
  2. Verified ping is sent
    image
  3. Move the clock 24h forward
  4. Verified ping is sent
    image

Scenario 4 - Upgrade 1.8.96 -> 1.9.76

  1. Installed 1.8.96
  2. Verified ping is sent
    image
  3. Move the clock 24h forward
  4. Update to 1.9.76
  5. Verified ping is sent
    image
  6. Move the clock 24h forward
  7. Verified ping is sent

Verification passed on

Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Scenario 1 (Upgrade case w/ non-default promo code):

  1. Launch Charles.
  2. Installed 1.8.96
  3. Launch 1.8.96 using promoCode SGE733
  4. Confirmed I saw ping in Charles:
    image
  5. Close Brave. Update to 1.9.72.
  6. Move computer clock ahead one day.
  7. Launch Brave using 1.9.72.
  8. Confirmed I could reproduce the issue of not seeing a ping like above image.
  9. Close Brave. Update to 1.9.76
  10. Move computer clock ahead one day.
  11. Launch Brave using 1.9.76.
  12. Confirmed I saw ping in Charles:
    image

Scenario 2 (Upgrade case with default promo code):

  1. Launch Charles.
  2. Installed 1.8.96
  3. Launch 1.8.96 without a promoCode (uses default BRV001)
  4. Confirmed I saw ping in Charles.
    image
  5. Close Brave. Update to 1.9.72.
  6. Move computer clock ahead one day.
  7. Launch Brave using 1.9.72
  8. Confirmed I could reproduce the issue of not seeing a ping like above image.
  9. Close Brave. Update to 1.9.76.
  10. Move computer clock ahead one day.
  11. Launch brave using 1.9.76.
  12. Confirmed I saw ping in Charles.
    image

Scenario 3 (Clean install of 1.9.76):

  1. Launch Charles.
  2. Installed 1.9.76.
  3. Launch 1.9.76 without a promoCode (uses default BRV001).
  4. Confirmed I saw ping in Charles.
    image
  5. Close Brave.
  6. Move computer clock ahead one day.
  7. Launch again.
  8. Confirmed I saw ping in Fiddler.
    image

@rebron rebron changed the title Usage pings not being sent for users migrating to 1.9.72 Stats ping not being sent for users who updated to 1.9.72 May 29, 2020
@LaurenWags LaurenWags mentioned this issue May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkuehlz kkuehlz

Labels
priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.9.x - Release Hotfix 1
Development

Successfully merging a pull request may close this issue.

bug: Ensure usage pings sent on browser upgrade brave/brave-core
6 participants
@bsclifton @rebron @LaurenWags @kkuehlz @btlechowski @GeetaSarvadnya