Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Ensure usage pings sent on browser upgrade (uplift to 1.10.x) #5640

Merged
merged 1 commit into from
May 23, 2020
Merged

bug: Ensure usage pings sent on browser upgrade (uplift to 1.10.x) #5640

merged 1 commit into from
May 23, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 23, 2020 •
edited by bsclifton
Loading

Uplift of #5635
Fixes brave/brave-browser#9921

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team May 23, 2020 16:37
@brave-builds brave-builds self-assigned this May 23, 2020
@brave-builds brave-builds added this to the 1.10.x - Beta milestone May 23, 2020
@bsclifton
Copy link
Member

Merging so we can do a test and verify before merging to Release. Unfortunately, not able to test on Nightly
cc: @keur

bsclifton
bsclifton approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 9db814e into 1.10.x May 23, 2020
@bsclifton bsclifton deleted the pr5635_usage_pings_upgrading_users_1.10.x branch May 23, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases