Icon Updates #548
Icon Updates #548
Conversation
rossmoody
requested review from
petemill,
bbondy,
simonhong and
bradleyrichter
|
I think you forgot to delete |
|
@simonhong this one is ready for a review. had a few additional permissions icons i wanted to squeeze in |
| @@ -32,7 +32,7 @@ void BraveAutoplayBlockedImageModel::UpdateFromWebContents( | |||
|
|
|||
| set_visible(true); | |||
| const gfx::VectorIcon* badge_id = &kBlockedBadgeIcon; | |||
| const gfx::VectorIcon* icon = &kExtensionIcon; | |||
| const gfx::VectorIcon* icon = &kPlayArrowIcon; | |||
There was a problem hiding this comment.
I think I'll change this to add a new icon
petemill
force-pushed
the
icon-updates
branch
2 times, most recently
from
ccdc604 to
9392ffe
Compare
| @@ -0,0 +1,44 @@ | |||
| // This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
This icon doesn't seem to be working @rossmoody - where did you intend it to go - on the tab?
There was a problem hiding this comment.
So looks like this icon is only included on the macOS build, possibly related to touchbar, though I couldn't get it to show up. Let's keep it in, but if we also want to change the default favicon, I think we'll need to provide PNGs @rossmoody . I'll create a separate issue
- general icon aesthetic and ver fine polish updates - adjusted menu to kabob instead of dots - settings omnibox lion now is full color - house is more housey - omnibox https security chip icons are revised to spec - adjusted autoplay icon from extension to a play button icon - incognito icon went from weird robber guy to cool sunglasses - Page action icons (magnify, find-in-page, autoplay, cookies, generic extension) - Some default favicon but not the real tab bar default favicon - removed the unused VR icon Use new icon for blocked autoplay graphic, since the usage of it is a new feature.
There was a problem hiding this comment.
Nice work @rossmoody - great digging to find some of these! 👨🎨
|
Passed internal security review |
Fix brave/brave-browser#1434
Fixes brave/brave-browser#1390
Fixes brave/brave-browser#1203
Fixes brave/brave-browser#1385
Use new icon for blocked autoplay graphic, since the usage of it is a new feature.