Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise icon for Brave internal pages #1390

Closed
rossmoody opened this issue Oct 2, 2018 · 1 comment
Closed

Revise icon for Brave internal pages #1390

rossmoody opened this issue Oct 2, 2018 · 1 comment
Assignees
@rossmoody
Labels
design A design change, especially one which needs input from the design team misc/icons QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Oct 2, 2018 •
edited by petemill
Loading

Description

Our internal pages utilize the Brave lion logo but on Dark theme the lion is reversed and takes on the dreaded tiny face aesthetic. This just needs updated to a full color lion in both instances.

image

Steps to Reproduce

  1. Go to settings
  2. Look at the sad tiny face lion.

Actual

  1. Feel shame

Expected

image
@rossmoody rossmoody added design A design change, especially one which needs input from the design team misc/icons labels Oct 2, 2018
@rossmoody rossmoody added this to the 1.0 (0.56.x) milestone Oct 2, 2018
@rossmoody rossmoody self-assigned this Oct 2, 2018
@rossmoody rossmoody mentioned this issue Oct 2, 2018
Merged
@petemill petemill added the QA/Yes label Oct 4, 2018
@petemill petemill modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 4, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 10, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

image

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows

image

Verified passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

screen shot 2018-10-11 at 9 44 23 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
design A design change, especially one which needs input from the design team misc/icons QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@petemill @srirambv @LaurenWags @rossmoody @GeetaSarvadnya