Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes widget title alignment, content padding #5323

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fixes widget title alignment, content padding #5323

merged 1 commit into from
Apr 23, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 22, 2020

Fixes brave/brave-browser#9403

left/right padding was increased from 15px -> 20px, some other css adjustments had to be made to compensate

Screen Shot 2020-04-22 at 2 07 13 PM

Screen Shot 2020-04-22 at 2 07 19 PM

Submitter Checklist:

Test Plan:

Defined in issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.10.x - Nightly milestone Apr 22, 2020
@ryanml ryanml self-assigned this Apr 22, 2020
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanml
Copy link
Contributor Author

ryanml commented Apr 23, 2020

All pipeline steps pass, failure is due to unrelated browser test:

15:34:03  [  FAILED  ] BraveRewardsBrowserTest.PanelShowsCorrectPublisherData, where TypeParam =  and GetParam() =  (5745 ms)
15:34:03  [548/549] BraveRewardsBrowserTest.PanelShowsCorrectPublisherData (6026 ms)
15:34:07  [549/549] BraveRewardsBrowserTest.ProcessPendingContributions (4977 ms)
15:34:07  1 test failed:
15:34:07      BraveRewardsBrowserTest.PanelShowsCorrectPublisherData (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:1713)
15:34:07  null
15:34:07  null

@ryanml ryanml merged commit fbc414e into master Apr 23, 2020
@ryanml ryanml deleted the padding-fix branch April 23, 2020 01:39
ryanml added a commit that referenced this pull request Apr 23, 2020
Fixes widget title alignment, content padding
bsclifton pushed a commit that referenced this pull request Apr 24, 2020
Fixes widget title alignment, content padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto Widget title alignment is off
4 participants