Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Widget title alignment is off #9403

Closed
ryanml opened this issue Apr 22, 2020 · 3 comments · Fixed by brave/brave-core#5323
Closed

Crypto Widget title alignment is off #9403

ryanml opened this issue Apr 22, 2020 · 3 comments · Fixed by brave/brave-core#5323

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 22, 2020

Description

Widget titles aren't aligned when Binance is in the foreground

Steps to Reproduce

  1. Put the Binance widget in the foreground on NTP

Actual result:

Titles are not aligned
Screen Shot 2020-04-22 at 2 24 37 PM

Expected result:

Screen Shot 2020-04-22 at 2 07 13 PM

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Apr 24, 2020

Verified alignment issue looks good to match expected result above. Clicked on both widgets to ensure alignment was consistent.

Brave 1.10.9 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS macOS Version 10.15.5 (Build 19F62f)

Screen Shot 2020-04-24 at 3 43 23 PM

@rebron
Copy link
Collaborator

rebron commented Apr 24, 2020

Verified alignment issue looks good to match expected result above. Clicked on both widgets to ensure alignment was consistent.

Brave 1.10.9 Chromium: 81.0.4044.122 (Official Build) nightly (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1903 (Build 18362.720)

alignment

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 27, 2020

Verification passed on

Brave 1.8.84 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan from the description

image

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS
  • Verified the test plan from the description

image
image

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.15.4 (Build 19E287)

Not connected:

Screen Shot 2020-04-28 at 2 31 26 AM

Cconnected:

Screen Shot 2020-04-28 at 2 32 53 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment