Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce custom interval for checking component update #4991

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 20, 2020

This can help component update test more easily.
issue: brave/brave-browser#8762

Resolves brave/brave-browser#8762

Submitter Checklist:

Test Plan:

  1. Launch browser with --component-update-interval-in-sec=60 switch
  2. Load brave://components and see update is checked every 60 secs

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.8.x - Nightly milestone Mar 20, 2020
@simonhong simonhong self-assigned this Mar 20, 2020
@simonhong simonhong requested a review from iefremov March 20, 2020 07:41
common/brave_switches.cc Outdated Show resolved Hide resolved
This can help component update test more easily.
issue: brave/brave-browser#8762
@simonhong simonhong force-pushed the add_custom_component_update_interval_switch branch from 79056e5 to b9e8932 Compare March 21, 2020 00:43
@simonhong
Copy link
Member Author

Merged because only test-install step was failed.

@simonhong simonhong merged commit af27b26 into master Mar 22, 2020
@simonhong simonhong deleted the add_custom_component_update_interval_switch branch March 22, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce command line switch to have shorter component update checking interval
2 participants