Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce command line switch to have shorter component update checking interval #8762

Closed
simonhong opened this issue Mar 19, 2020 · 3 comments · Fixed by brave/brave-core#4991
Closed

Introduce command line switch to have shorter component update checking interval #8762

simonhong opened this issue Mar 19, 2020 · 3 comments · Fixed by brave/brave-core#4991
Assignees
@simonhong
Labels
dev-concern misc/command-line-args OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.8.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Mar 19, 2020 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#4991

Description

Brave checks component update right after the launching for our some components or some minutes later. Then periodically checks the new update every 5 hours in background.
It would be good to have shorter background timer to test component update during the runtime.
@simonhong simonhong self-assigned this Mar 19, 2020
@simonhong simonhong added this to the 1.8.x - Nightly milestone Mar 19, 2020
simonhong added a commit to brave/brave-core that referenced this issue Mar 20, 2020
@simonhong
Introduce custom interval for checking component update
79056e5 
This can help component update test more easily.
issue: brave/brave-browser#8762
@simonhong simonhong mentioned this issue Mar 20, 2020
Merged
32 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 21, 2020
@simonhong
Introduce custom interval for checking component update
b9e8932 
This can help component update test more easily.
issue: brave/brave-browser#8762
@LaurenWags
Copy link
Member

Marking as QA/Blocked for now - discussing with @simonhong 😄

@simonhong
Copy link
Member Author

OMG, command line switch name was changed to component-update-interval-in-sec during the code review. but forgot to update in issue's description. Sorry for this inconvenience.

@LaurenWags
Copy link
Member

LaurenWags commented Apr 24, 2020 •
edited by btlechowski
Loading

Thanks for the update @simonhong 😄 works like a charm now!

Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
dev-concern misc/command-line-args OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Introduce custom interval for checking component update brave/brave-core
5 participants
@bsclifton @simonhong @LaurenWags @btlechowski @GeetaSarvadnya