Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BraveThemeServiceTest failure #480

Closed
wants to merge 1 commit into from

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 19, 2018

Recently, frame colors were changed.
Failure reason is this test uses hard-coded color value.
As a todo list, we should share these color constants instead of copying.

Issue brave/brave-browser#961

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

yarn test brave_browser_tests --filter=BraveThemeServiceTest.BraveThemeChangetest

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Recently, frame colors were changed.
Failure reason is this test uses hard-coded color value.
As a todo list, we should share these color constants instead of copying.
@simonhong simonhong self-assigned this Sep 19, 2018
@simonhong
Copy link
Member Author

Closed by #482

@simonhong simonhong closed this Sep 20, 2018
@simonhong simonhong deleted the fix_brave_theme_service_test branch September 29, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants