Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light theme color refinement #961

Closed
petemill opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#477
Closed

Light theme color refinement #961

petemill opened this issue Sep 4, 2018 · 3 comments · Fixed by brave/brave-core#477
Assignees
@petemill
Labels
feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

petemill commented Sep 4, 2018 •
edited
Loading

brave/brave-core#391 covers dark and private themes with regards to colors. Light theme still needs refinement according to spec.

Test plan

  • Switch to light theme
    Looks like this on macOS, and Windows and Linux (with classic theme)
    image
@petemill petemill added this to the Releasable builds 0.55.x milestone Sep 4, 2018
@petemill petemill self-assigned this Sep 4, 2018
@petemill petemill mentioned this issue Sep 4, 2018
Merged
14 tasks
@srirambv srirambv added feature/user-interface All UI related and removed feature/ui labels Sep 18, 2018
petemill added a commit to brave/brave-core that referenced this issue Sep 19, 2018
@petemill
Iterate the UI light theme
1151764 
Fix brave/brave-browser#961

Hardcoded colors for now, will follow-up with variables for the palette and re-using from Omnibox to ThemeProperties when we validate these values with the designers in the build.
@petemill petemill mentioned this issue Sep 19, 2018
Merged
11 tasks
@simonhong simonhong mentioned this issue Sep 19, 2018
Closed
11 tasks
@petemill petemill mentioned this issue Sep 20, 2018
Closed
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@LaurenWags
Copy link
Member

@petemill could you help with a Test Plan for this one?

@petemill
Copy link
Member Author

Test plan added

@srirambv
Copy link
Contributor

srirambv commented Oct 18, 2018 •
edited by GeetaSarvadnya
Loading

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Linux

image

Verified passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

screen shot 2018-10-17 at 10 22 10 pm

Verification Passed on

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (32-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Iterate the UI light theme brave/brave-core
5 participants
@petemill @bbondy @srirambv @LaurenWags @GeetaSarvadnya