Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not calling CloseSelectedTabs() in CW reset action #4669

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Not calling CloseSelectedTabs() in CW reset action #4669

merged 1 commit into from
Feb 19, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Feb 17, 2020

Fixes: brave/brave-browser#8286

To be used with: brave/ethereum-remote-client#106

Description in issue

Submitter Checklist:

Test Plan:

There isn't really a visible effect of this than can be tested without the UI. It can be seen here (https://github.com/brave/brave-core/blob/master/components/brave_wallet/browser/brave_wallet_controller.cc#L184) that code exists to close any remaining CW tabs.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.6.x - Nightly milestone Feb 17, 2020
@ryanml ryanml requested a review from bbondy February 17, 2020 20:59
@ryanml ryanml self-assigned this Feb 17, 2020
@ryanml ryanml merged commit 613cff1 into master Feb 19, 2020
@ryanml ryanml deleted the fix-8286 branch February 19, 2020 16:44
ryanml added a commit that referenced this pull request Feb 25, 2020
Not calling CloseSelectedTabs() in CW reset action
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current tab should not be closed via BraveWalletController::CloseTabsAndRestart
2 participants