Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current tab should not be closed via BraveWalletController::CloseTabsAndRestart #8286

Closed
ryanml opened this issue Feb 17, 2020 · 0 comments · Fixed by brave/brave-core#4669
Closed

Current tab should not be closed via BraveWalletController::CloseTabsAndRestart #8286

ryanml opened this issue Feb 17, 2020 · 0 comments · Fixed by brave/brave-core#4669
Assignees
@ryanml
Labels
dev-concern feature/ethereum-remote-client QA/No release-notes/exclude
Milestone
1.5.x - Release

Comments

@ryanml
Copy link
Contributor

ryanml commented Feb 17, 2020 •
edited
Loading

Related to the implementation of: #5741

When done here (https://github.com/brave/brave-core/blob/master/components/brave_wallet/browser/brave_wallet_controller.cc#L180) preceding the closing of all Crypto Wallets tab, this can cause race conditions. The current tab should be closed from the extension itself via the chrome.tabs api, then this code can execute before unload
@ryanml ryanml added QA/No dev-concern feature/web3/wallet Integrating Ethereum+ wallet support labels Feb 17, 2020
@ryanml ryanml added this to the 1.6.x - Nightly milestone Feb 17, 2020
@ryanml ryanml self-assigned this Feb 17, 2020
@ryanml ryanml mentioned this issue Feb 17, 2020
Merged
32 tasks
@ryanml ryanml modified the milestones: 1.6.x - Nightly, 1.5.x - Dev Feb 17, 2020
ryanml added a commit to brave/brave-core that referenced this issue Feb 18, 2020
@ryanml
Fixes brave/brave-browser#8286 - not closing current tab on CW reset
8e03433
@ryanml ryanml mentioned this issue Feb 25, 2020
Merged
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this issue Mar 11, 2020
@ryanml @jonathanKingston
Fixes brave/brave-browser#8286 - not closing current tab on CW reset
c37dfdd
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
dev-concern feature/ethereum-remote-client QA/No release-notes/exclude
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

Not calling CloseSelectedTabs() in CW reset action brave/brave-core
3 participants
@ryanml @srirambv @LaurenWags