Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes upgrade from 0.63.x to 1.3.x AC switch OFF and wallet creation failed - 1.3.x #4450

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jan 28, 2020

@tmancey tmancey added this to the 1.3.x - Beta milestone Jan 28, 2020
@tmancey tmancey requested a review from a team January 28, 2020 11:30
@tmancey tmancey self-assigned this Jan 28, 2020
@tmancey tmancey removed the request for review from NejcZdovc January 28, 2020 11:31
@kjozwiak
Copy link
Member

kjozwiak commented Jan 28, 2020

Looks like test-install on macOS is the only failure as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F7833-1.3.x/1/execution/node/698/log/:

if [ ${CHANNEL} = "release" ]; then CHANNEL_CAPITALIZED_SPACED=""; else CHANNEL_CAPITALIZED="$(tr '[:lower:]' '[:upper:]' <<< ${CHANNEL:0:1})${CHANNEL:1}"; fi if [ ${CHANNEL} = "release" ]; then BROWSER="Brave Browser"; else BROWSER="Brave Browser ${CHANNEL_CAPITALIZED}"; fi OUT_DIR="${WORKSPACE}/src/out/${BUILD_TYPE}" if [ ${SKIP_SIGNING} = true ] ; then hdiutil attach -nobrowse "${OUT_DIR}/unsigned_dmg/${BROWSER}.dmg" else hdiutil attach -nobrowse "${OUT_DIR}/${BROWSER}.dmg" fi sleep 10 open "/Volumes/${BROWSER}/${BROWSER}.app" sleep 10 pkill Brave VOLUME=$(diskutil list | grep "Brave Browser" | awk -F'MB ' '{ print $2 }') declare -a arr=($VOLUME) # loop through the above array to eject all volumes for i in "${arr[@]}" do diskutil unmountDisk force $i diskutil eject $i done

This is a known issue that's not due to this specific PR. Waiting for #4449 to be merged and checked on Nightly.

@bsclifton
Copy link
Member

marked as blocked since we'll want to merge #4449 and check on Nightly 👍

@tmancey
Copy link
Collaborator Author

tmancey commented Jan 28, 2020

@kjozwiak

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bsclifton
Copy link
Member

marking as unblocked as this was verified on Nightly 🎉

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. Only failure was on macOS due to test-install as per #4450 (comment) which is a known issue. @LaurenWags also went through the PR on Nightly as per #4449 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit f73dadc into 1.3.x Jan 31, 2020
@kjozwiak kjozwiak deleted the issues/7833-1.3.x branch January 31, 2020 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants