Upgrade from 0.63.x to 1.3.x resets Ads viewed count to zero, AC switch OFF and wallet creation failed

[GeetaSarvadnya]

Description

Upgrade from 0.63.x to 1.3.x resets Ads viewed count to zero, AC switch OFF and wallet creation failed.

Steps to Reproduce

1. Clean profile 0.63.35
2. Enable rewards and view an ad
3. Upgrade to 1.3.94
4. After upgrade, Ads viewed count resets to 0.0 BAT and Auto contribution switch is turned OFF and wallet creation is failed.

Actual result:

After upgrade, Ads viewed count resets to 0.0 BAT and Auto contribution switch is turned OFF and wallet creation is failed.
0.63.35 -->1.3.94

0.63.55-->1.2.43 - Works fine

Expected result:

Ads count should not be reset to zero and AC and rewards should be in ON state after upgrade

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

• Can you reproduce this issue with the current release? 0.63.55 -->1.2.42 - works fine
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Not sure
• Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @tmancey @jsecretan @rebron

[tmancey]

@NejcZdovc Bug is due to state being reset due to WALLET_PROPERTIES_ST JSON changes in e3b5f827c2756cd19eee0c01ba15eea803a4db25 as there is no migration path

The issue affects upgrading from any version before 0.65.59.

@GeetaSarvadnya With regards to the ads issue where "Ad notifications received this month" are reset to 0, it was decided when working on "7-day ads history" that legacy ads history would be reset (however this will not affect users "Estimated rewards pending"

[LaurenWags]

Reproduced when going from 0.63.55 --> 1.5.53 (Nightly)

Brave	1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Per @tmancey note #7833 (comment) that this will occur for any upgrade before 0.65.59, we should decide if we're going to fix this one since that is a fairly old version.

cc @kjozwiak @rebron

Update, if you're upgrading from a non-ads enabled region I'm seeing Rewards OFF entirely and the "uh oh" message on the wallet panel:

Brave	1.5.56 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Versión 10.14.6 (Fase 18G103)

[LaurenWags]

Could not reproduce with 1.2.x. Steps:

1. Install 0.63.55 (Release)
2. Enable Rewards, trigger an Ad
3. Upgrade using brave://settings/help to 1.2.43
4. Relaunch
5. Navigate to brave://rewards
   ---> no issues on brave://rewards page. Ads panel is displayed as expected, nothing is toggled off, no error messages.

0.63.55 Before upgrading to 1.2.43:

After upgrading to 1.2.43:

---

Reproduced with 1.3.x:

1. Install 0.63.55 (Release)
2. Enable Rewards, trigger an Ad
3. Close. Rename profile to Beta.
4. Launch Beta 1.3.99
5. Navigate to brave://rewards
   ---> multiple issues on page:
   • Uh Oh message on wallet panel
   • Ads viewed this month is reset to 0/Estimated pending shows 0
   • No date for Ads payout
   • AC is toggled off
   • if I scroll down, my 'Monthly Contributions' panel date is screwed up (says Dec 31)

0.63.55 before upgrading to 1.3.99:

after upgrade to 1.3.99:

Toggling Rewards off/on resets the Ads panel visually at least. However, it doesn't fix the 'Uh oh' message. Additionally, when doing this, then i see the "Wallet Creation Failed" on the panel:

Brave	1.3.99 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

[GeetaSarvadnya]

Verification passed on

Brave	1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the STR from the description
• Verified Upgrade from 0.63.x to 1.3.x resets Ads viewed count to zero, AC switch OFF and wallet creation failed #7833 (comment)
  Before upgrade 0.63.55
  
  After upgrade 1.3.107 Ads panel displayed as expected, no rewards error, nothing is toggled off
  
• Verified upgrade from 1.2.42 to 1.3.107 - Ads panel displayed as expected, no rewards error, nothing is toggled off

Verified passed with

Brave	1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Scenario 1: 1. 0.63.55

• Install above version.
• Enable Rewards, view an ad
• Close. Rename profile to Beta.
• Launch 1.3.108
• Ads panel displays as expected, AC is still on as expected, no error on wallet panel as expected

Scenario 2: 0.64.77

• Install above version.
• Enable Rewards, view an ad
• Close. Rename profile to Beta.
• Launch 1.3.108
• Ads panel displays as expected, AC is still on as expected, no error on wallet panel as expected

Scenario 3: 1. 1.1.23

• Install above version.
• Enable Rewards, view an ad
• Close. Rename profile to Beta.
• Launch 1.3.108
• Ads panel displays as expected, AC is still on as expected, no error on wallet panel as expected

Scenario 4: 1.2.43

• Install above version.
• Enable Rewards, view an ad
• Close. Rename profile to Beta.
• Launch 1.3.108
• Ads panel displays as expected, AC is still on as expected, no error on wallet panel as expected

Verification passed on

Brave	1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision	cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS	Ubuntu 18.04 LTS

Verified for following upgrades: 0.63.55, 0.64.77, 1.1.23, 1.2.43
Verified Ads panel displays as expected, AC is still on as expected, no error on wallet panel as expected