Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds cc scope for uphold (uplift to 1.4.x) #4409

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Adds cc scope for uphold (uplift to 1.4.x) #4409

merged 1 commit into from
Jan 24, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 22, 2020 •
edited by NejcZdovc
Loading

Uplift of #4379

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Jan 22, 2020
@brave-builds brave-builds added this to the 1.4.x - Dev milestone Jan 22, 2020
@NejcZdovc NejcZdovc removed their request for review January 22, 2020 19:46
@kjozwiak
Copy link
Member

Restarting iOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4379_uphold-scope_1.4.x/1/execution/node/257/log/ failing.

Restarting Linux due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4379_uphold-scope_1.4.x/1/execution/node/134/log/ failing.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/pr4379_uphold-scope_1.4.x/1/execution/node/314/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-windows labels Jan 22, 2020
@kjozwiak
Copy link
Member

Looks like it failed to fetch the repo on macOS as per https://ci.brave.com/job/brave-browser-build-pr/job/pr4379_uphold-scope_1.4.x/2/execution/node/230/log/. Going to restart macOS and see if that helps.

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Jan 23, 2020
@kjozwiak
Copy link
Member

Looks like macOS failed again... Restarting due to the following failures:

kjozwiak
kjozwiak approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. Both CI/Travis and CI/Jenkins passed without any issues. @LaurenWags also went through #4379 (comment) and verified that Uphold was still working.

Please ensure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit d890a1f into 1.4.x Jan 24, 2020
@kjozwiak kjozwiak deleted the pr4379_uphold-scope_1.4.x branch January 24, 2020 21:37
@kjozwiak kjozwiak mentioned this pull request Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases