Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cc scope for uphold #4379

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Adds cc scope for uphold #4379

merged 1 commit into from
Jan 22, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 15, 2020

Resolves brave/brave-browser#7713

Submitter Checklist:

Test Plan:

  • make sure that uphold still works correctly

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.5.x - Nightly milestone Jan 15, 2020
@NejcZdovc NejcZdovc requested review from jumde and a team January 15, 2020 21:05
@NejcZdovc NejcZdovc self-assigned this Jan 15, 2020
@NejcZdovc NejcZdovc force-pushed the uphold-scope branch 3 times, most recently from c5e540a to 448433c Compare January 15, 2020 21:45
@NejcZdovc
Copy link
Contributor Author

security review requested: https://github.com/brave/security/issues/54

Copy link
Contributor

@jumde jumde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please wait for approval of these scopes for production before merge.

@NejcZdovc NejcZdovc merged commit 970d3c4 into master Jan 22, 2020
@NejcZdovc NejcZdovc deleted the uphold-scope branch January 22, 2020 19:44
brave-builds pushed a commit that referenced this pull request Jan 22, 2020
brave-builds pushed a commit that referenced this pull request Jan 22, 2020
@LaurenWags
Copy link
Member

Verified using

Brave 1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (Build 18G103)

Using a KYC'd user wallet did:

  • 1 time tip
  • recurring tip
  • auto contribute
    Then, for each of the above,
  • verified it was recorded on brave://rewards
  • verified it was recorded on the panel
  • verified wallet balance decreased as expected
  • verified on browser relaunch, wallet balance was not reduced
  • contribution_info and contribution_info_publishers tables were populated as expected

See also: #4372 (comment) and #4399 (comment) for some additional KYC'd user wallet testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing scope for Uphold
4 participants