Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue 7500, phrasing in brave rewards messages #4276

Closed
wants to merge 2 commits into from

Conversation

darrylbutcher
Copy link
Contributor

@darrylbutcher darrylbutcher commented Dec 22, 2019

Fixes brave/brave-browser#7500

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Dec 22, 2019

@darrylbutcher thank you for the PR. Can you please do an adjustment for desktop version in components/resources/brave_components_strings.grd instead of .xtb. xtb is auto generated file, where grd is the source. Thank you

@darrylbutcher
Copy link
Contributor Author

@NejcZdovc switched the change into the xtb file

</translationbundle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darrylbutcher please revert this change

@NejcZdovc NejcZdovc self-requested a review December 23, 2019 08:09
@NejcZdovc
Copy link
Contributor

At the end please squash everything into one commit. Thank you

@darrylbutcher
Copy link
Contributor Author

Created clean PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Rewards : Copy Change on Settings
2 participants