Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards : Copy Change on Settings #7500

Closed
alexwykoff opened this issue Dec 20, 2019 · 5 comments · Fixed by brave/brave-core#4280
Closed

Brave Rewards : Copy Change on Settings #7500

alexwykoff opened this issue Dec 20, 2019 · 5 comments · Fixed by brave/brave-core#4280

Comments

@alexwykoff
Copy link

Per feedback : https://twitter.com/gridinoc/status/1207874459547385857

Please change “ads in” to “ad notifications with” on the Rewards Settings page, Ads Settings panel.

@alexwykoff alexwykoff added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Dec 20, 2019
@mandar-brave mandar-brave added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 21, 2019
@mandar-brave
Copy link

Making this easier.
Earn tokens by viewing Brave Ads (instead of Earn tokens by viewing Ads in Brave).

cc @jenn-rhim @alexwykoff

@darrylbutcher
Copy link

created a PR for the fix for English strings in browser and android

@NejcZdovc NejcZdovc assigned darrylbutcher and unassigned NejcZdovc Dec 22, 2019
@NejcZdovc NejcZdovc removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Dec 22, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 23, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.4.x - Dev, 1.5.x - Nightly Jan 1, 2020
@LaurenWags
Copy link
Member

@mandar-brave per #7500 (comment) you have Ads capitalized. It is currently not capitalized in 1.5.102. Please confirm if current implementation is ok:

Screen Shot 2020-02-27 at 10 25 17 AM

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

@mandar-brave
Copy link

Brave ads should be Brave Ads .

@LaurenWags
Copy link
Member

LaurenWags commented Feb 27, 2020

Verified passed with

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)
  • Reproduced original text on Ads panel using 1.4.95:

Screen Shot 2020-02-27 at 12 20 13 PM

  • Verified text is updated in 1.5.x:

ads

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Ubuntu 18.04 LTS

Verified test plan from the description
image
image

Verification passed on

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Reproduced original text on Ads panel using 1.4.95:
    image

  • Verified text is updated in 1.5.x:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment