Fixes crash for null ptr #4263
Merged
Fixes crash for null ptr #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
reviewed
Dec 19, 2019
tmancey
reviewed
Dec 19, 2019
| base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE, | ||
| base::BindOnce(&SavePublisherInfoOnFileTaskRunner, | ||
| publisher_info->Clone(), | ||
| std::move(copy), |
There was a problem hiding this comment.
If a developer is copy/pasting there is potential for a bug, a safer approach would be to clone publisher_info inline for each std::bind. However, as we all know, copy/paste is the root of all evil
NejcZdovc
commented
Dec 19, 2019
| base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE, | ||
| base::BindOnce(&SavePublisherInfoOnFileTaskRunner, | ||
| publisher_info->Clone(), | ||
| std::move(copy), |
There was a problem hiding this comment.
this was the main problem, why we saw crashes. If checks are just additional safety measurements
NejcZdovc
added
CI/skip-android
|
everything passed except Windows (build stopped), so restarting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7363
It was introduced in here #4120
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
don't have STR, but this was found from the crash reports and what @emerick found as well
Reviewer Checklist:
After-merge Checklist:
changes has landed on.