Switch tip where possible to tip via code #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
tip-via-code
branch
from
1674a38 to
d2f1177
Compare
NejcZdovc
commented
Dec 5, 2019
| @@ -72,14 +72,6 @@ chrome.braveRewards.onRecurringTipRemoved.addListener((success: boolean) => { | |||
| } | |||
| }) | |||
|
|
|||
| chrome.braveRewards.onPendingContributionSaved.addListener((result: number) => { | |||
There was a problem hiding this comment.
this code was duplicated
NejcZdovc
force-pushed
the
tip-via-code
branch
from
d2f1177 to
477487c
Compare
NejcZdovc
commented
Dec 5, 2019
| @@ -1189,7 +1189,7 @@ void RewardsServiceImpl::SavePublisherInfo( | |||
| ledger::PublisherInfoCallback callback) { | |||
| base::PostTaskAndReplyWithResult(file_task_runner_.get(), FROM_HERE, | |||
| base::BindOnce(&SavePublisherInfoOnFileTaskRunner, | |||
| std::move(publisher_info), | |||
| publisher_info->Clone(), | |||
There was a problem hiding this comment.
we need to clone as we use same pointer in second bind
NejcZdovc
force-pushed
the
tip-via-code
branch
3 times, most recently
from
d4ca210 to
bfd76ba
Compare
NejcZdovc
force-pushed
the
tip-via-code
branch
from
bfd76ba to
5ba2184
Compare
tmancey
approved these changes
Dec 10, 2019
| } | ||
|
|
||
| if (should_contribute) { | ||
| // Wait for reconciliation to complete |
There was a problem hiding this comment.
nit: comment is not required as code is self-documented
NejcZdovc
force-pushed
the
tip-via-code
branch
from
5ba2184 to
afe71af
Compare
|
CI failed on |
|
CI failed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7184
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.