Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve copyright statement (uplift to 0.73.x) #3956

Merged
merged 2 commits into from
Nov 10, 2019
Merged

Improve copyright statement (uplift to 0.73.x) #3956

merged 2 commits into from
Nov 10, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 9, 2019 •
edited
Loading

Uplift of #3828

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@fmarier
Improve licensing notice (fixes brave/brave-browser#6605)
b0e8df3 
This add a link to the license, build instructions as well as the
corresponding source code.
@fmarier
Link to release notes from brave://settings/help (fixes brave/brave-b…
8ea49ee 
…rowser#6152)

The version number on the about page should be a link to the page
for the latest release notes.
@fmarier fmarier added this to the 0.73.x - Dev milestone Nov 9, 2019
@fmarier fmarier self-assigned this Nov 9, 2019
kjozwiak
kjozwiak approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. This fix also uplifted into 0.71.x as per #3958 so we'll need it in the other channels. Both CI/Jenkins and CI/Travis passed without any failures.

@kjozwiak kjozwiak merged commit e3f0b4e into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the francois-improve-copyright-statement-3828-0.73.x branch November 10, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@fmarier fmarier

Labels
None yet
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarier @kjozwiak