Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve copyright statement (uplift to 0.71.x) #3958

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Improve copyright statement (uplift to 0.71.x) #3958

merged 2 commits into from
Nov 9, 2019

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Nov 9, 2019 •
edited by bsclifton
Loading

Fixes brave/brave-browser#6152 and brave/brave-browser#6605.
Uplift of #3828

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@fmarier
Improve licensing notice (fixes brave/brave-browser#6605)
92d58e4 
This add a link to the license, build instructions as well as the
corresponding source code.
@fmarier
Link to release notes from brave://settings/help (fixes brave/brave-b…
8873f2e 
…rowser#6152)

The version number on the about page should be a link to the page
for the latest release notes.
@fmarier fmarier added this to the 0.71.x - Release milestone Nov 9, 2019
@fmarier fmarier self-assigned this Nov 9, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv November 9, 2019 05:39
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 9, 2019
bsclifton
bsclifton approved these changes Nov 9, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 02f76b7 into 0.71.x Nov 9, 2019
@bsclifton bsclifton deleted the francois-improve-copyright-statement-3828-0.71.x branch November 9, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@fmarier fmarier

Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@fmarier @bsclifton