Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.73.x] Make NTP widget size to fit content #3941

Merged
merged 1 commit into from
Nov 10, 2019
Merged

[0.73.x] Make NTP widget size to fit content #3941

merged 1 commit into from
Nov 10, 2019

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Nov 8, 2019

fix brave/brave-browser#6746 for 0.73.x

Sibling PRs #3916, #3938

Make NTP widget size to fit content
@cezaraugusto cezaraugusto added this to the 0.73.x - Dev milestone Nov 8, 2019
@cezaraugusto cezaraugusto requested a review from a team November 8, 2019 18:43
@cezaraugusto cezaraugusto self-assigned this Nov 8, 2019
@kjozwiak
Copy link
Member

Restarting iOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6746-73/1/execution/node/466/log/ failing.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6746-73/1/execution/node/505/log/ failing.

Restarting Win x64 due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/ca-6746-73/1/execution/node/158/log/:

14:27:35  HEAD is now at 0e9afd2a Change "CPU time" to "elapsed time"
14:27:35  Done updating submodules...
14:27:35  Syncing Gclient (with reset)
14:27:35  C:\6-73: gclient sync --force --nohooks --with_branch_heads --with_tags --upstream
14:27:35  Downloading CIPD client for windows-amd64 from https://chrome-infra-packages.appspot.com/client?platform=windows-amd64&version=git_revision:2a121dde003a3079db0fdf58195b52cbf486f6ba...
14:27:47  Cannot contact i-07088c87be60a8f93: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@6e521720:i-07088c87be60a8f93": Remote call on i-07088c87be60a8f93 failed. The channel is closing down or has closed down

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 10, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 690a079 into 0.73.x Nov 10, 2019
@kjozwiak kjozwiak deleted the ca-6746-73 branch November 10, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants