Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.72.x] Make NTP widget size to fit content #3938

Merged
merged 1 commit into from
Nov 10, 2019
Merged

[0.72.x] Make NTP widget size to fit content #3938

merged 1 commit into from
Nov 10, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#6746 for 0.72.x

Sibling PR for Nightly #3916

@cezaraugusto
Merge pull request #3916 from brave/ca-6746
9661926 
Make NTP widget size to fit content
@cezaraugusto cezaraugusto requested a review from a team November 8, 2019 18:16
@cezaraugusto cezaraugusto self-assigned this Nov 8, 2019
@cezaraugusto cezaraugusto mentioned this pull request Nov 8, 2019
Merged
@cezaraugusto cezaraugusto added this to the 0.72.x - Beta milestone Nov 8, 2019
@kjozwiak
Copy link
Member

Restarting iOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6746-72/1/execution/node/582/log/ failing.

Restarting macOS due to https://ci.brave.com/job/brave-browser-build-pr/job/ca-6746-72/1/execution/node/556/log/ failing.

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 10, 2019
kjozwiak
kjozwiak approved these changes Nov 10, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.72.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 6314806 into 0.72.x Nov 10, 2019
@kjozwiak kjozwiak deleted the ca-6746-72 branch November 10, 2019 19:14
@bsclifton bsclifton mentioned this pull request Nov 11, 2019
Closed
@cezaraugusto cezaraugusto mentioned this pull request Nov 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @kjozwiak