Makes twitter tip actions keyboard accessible #3253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
force-pushed
the
fix-5791
branch
2 times, most recently
from
28cb81e
to
503f316
Compare
ryanml
commented
Aug 24, 2019
| @@ -275,6 +277,21 @@ document.addEventListener('visibilitychange', function () { | |||
| } | |||
| }) | |||
|
|
|||
| // Listens for enter key when Tip action is tab-highlighted | |||
| document.addEventListener('keydown', function (e) { | |||
| if (e.key === 'Enter') { | |||
There was a problem hiding this comment.
RIP KeyboardEvent.keyCode 👻
NejcZdovc
previously requested changes
Aug 26, 2019
There was a problem hiding this comment.
please check CI
ERROR in [at-loader] ./components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts:284:26
22:47:26 TS2531: Object is possibly 'null'.
22:47:26
22:47:26 ERROR in [at-loader] ./components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts:287:25
22:47:26 TS2531: Object is possibly 'null'.
22:47:26
22:47:26 ERROR in [at-loader] ./components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts:287:25
22:47:26 TS2531: Object is possibly 'null'.
22:47:26
22:47:26 ERROR in [at-loader] ./components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts:289:19
22:47:26 TS2339: Property 'click' does not exist on type 'Element'.
3ae4059
to
5acb7ac
Compare
petemill
previously requested changes
Aug 26, 2019
There was a problem hiding this comment.
This will need to work on space (as well as enter) enter, like the other twitter actions. I wonder if just making it a element will have the same effect without this hack, and then also gain the other built-in accessibility features? If not possible, then please at least add support for space unless you see a reason not to.
ryanml
commented
Aug 26, 2019
| @@ -275,6 +277,33 @@ document.addEventListener('visibilitychange', function () { | |||
| } | |||
| }) | |||
|
|
|||
| // Listens for enter key when Tip action is tab-highlighted | |||
| document.addEventListener('keydown', function (e) { | |||
| if (e.key !== 'Enter' || e.code !== 'Space') { | |||
There was a problem hiding this comment.
KeyboardEvent.key equals a single blank space " " for space bar presses, using the code property for readability
petemill
reviewed
Aug 26, 2019
components/brave_rewards/resources/extension/brave_rewards/content_scripts/twitter.ts
Outdated
Show resolved
Hide resolved
petemill
approved these changes
Aug 27, 2019
|
CI failure unrelated, version mismatch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#5791
Note: It wasn't mentioned in the document, but tab selecting the tip actions didn't work at all, so this PR fixes that as well.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Test plan is specified in issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.