Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter tip actions should be tab-selectable, and accessible via enter key #5791

Closed
ryanml opened this issue Aug 24, 2019 · 1 comment · Fixed by brave/brave-core#3253
Closed

Comments

@ryanml
Copy link
Contributor

ryanml commented Aug 24, 2019

Currently, you are unable to tab focus twitter tip actions on tweets, you should be able to tab-select them, then hit 'Enter' to engage the tipping banner. The goal is to have this achievable without clicks, for accessibility purposes.

Test plan:

  1. Go to your twitter feed or a twitter user's page such as https://twitter.com/BrendanEich
  2. Using tab, select through elements until you highlight a tip action
  3. Press the enter key
  4. Confirm the tip banner appears for the appropriate user
  5. Repeat steps 2 - 4 a few times within in the same feed to ensure that the correct user info is shown for different tweets in the banner
@btlechowski
Copy link

btlechowski commented Oct 8, 2019

Verification passed on

Brave 0.70.109 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

image

Verification passed on

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the description

image

image

image

image

Verified passed with

Brave 0.70.112 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from description
    Able to select Tip button on a tweet with tab:

Screen Shot 2019-10-10 at 5 20 56 PM

Able to select with Enter:
Screen Shot 2019-10-10 at 5 21 08 PM

Confirmed that selecting Tip button (for a retweet) further down the feed shows the expected info in banner:
Screen Shot 2019-10-10 at 5 20 36 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment