Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.68.x [brave-extension] prevent allow scripts once button from visible in resources overlay #3192

Closed
wants to merge 1 commit into from

Conversation

cezaraugusto
Copy link
Contributor

[brave-extension] prevent allow scripts once button from being visible in resources overlay

uplift request for brave/brave-browser#5486

[brave-extension] prevent `allow scripts once` button from being visible in resources overlay
@cezaraugusto cezaraugusto added this to the 0.68.x - Release milestone Aug 15, 2019
@cezaraugusto cezaraugusto requested a review from a team August 15, 2019 16:10
@cezaraugusto cezaraugusto self-assigned this Aug 15, 2019
kjozwiak
kjozwiak previously approved these changes Aug 21, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with @brave/uplift-approvers a few days ago, we decided that this wasn't critical enough to merge into 0.68.x which is being released today.

@kjozwiak kjozwiak dismissed their stale review August 21, 2019 16:57

Accidentally selected "Approve" rather than "Comment"

@kjozwiak kjozwiak closed this Aug 21, 2019
@kjozwiak kjozwiak removed this from the 0.68.x - Release milestone Aug 21, 2019
@bsclifton bsclifton deleted the ca-5486-68 branch September 15, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants