Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Menu gets Create Profile and Switch to Guest Profile items #3096

Merged
merged 1 commit into from
Aug 6, 2019

Conversation

petemill
Copy link
Member

@petemill petemill commented Aug 6, 2019

Fix brave/brave-browser#5212

Submitter Checklist:

Test Plan:

  • Create New Profile item only shows on normal / incognito / tor windows, not guest window.
  • Open Guest Window item only shows on normal / incognito / tor windows, not guest window.
  • Menu item positions are as in mockup in issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton merged commit 2213118 into master Aug 6, 2019
@bsclifton bsclifton deleted the profile-app-menu branch August 6, 2019 18:10
@bsclifton bsclifton added this to the 0.70.x - Nightly milestone Aug 6, 2019
@@ -54,6 +54,19 @@ void BraveAppMenuModel::InsertBraveMenuItems() {
IDS_SHOW_BRAVE_SYNC);
}
}

// Insert Create New Profile item
auto profile_items_insert_index = GetIndexOfCommandId(IDC_ZOOM_MENU) - 1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probbaly should only have inserted these items if the session isn't a guest session. Right now, the items show as disabled but not hidden. The spec was unclear ;-) I can clean up in brave/brave-browser#5552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Profile Manager items to App menu
4 participants