Add Profile Manager items to App menu

[rebron]

Description

Add Profile Manager items to the hamburger menu.

1. 'Create New Profile' -> creates a new profile and launches into brave://welcome with that new profile.
2. 'Open Guest Window' -> launches into a new Guest Window

Design

[rebron]

@bradleyrichter Can you confirm final on mock above?

[bradleyrichter]

@rebron looks good

[petemill]

@bradleyrichter @rebron can I ask to confirm the ellipses (or lack of) in the mockup.

Create a New Profile… and Open Guest Window (and New X Window for that matter) all do the same thing - open another window, so I'm not sure why Create New Profile would be the only one ending with an ellipsis. Please could you explain?

[rebron]

I believe it means more options will be showing and more info will be needed whereas without the ellipses a user will be going to that thing and no other info is needed. So with create a new profile... the more info needed is select an icon and edit a name (or just use the default name provided).

[petemill]

@rebron sure, but in this case the user is not prompted for more information, the new profile simply opens. See the existing macOS system menu Profile - Add Profile option

[rebron]

@bradleyrichter We should remove the ellipsis in this case then and it should just be Create a New Profile.

[GeetaSarvadnya]

@petemill brave/brave-core#3096 - Would need some clarifications regarding the test plan, should it be as mentioned below? Please let me know if I am missing anything in testing notes #5212 (comment)

1. The Create New Profile item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
2. The Guest Window item available only in Normal and Private/Incognito windows Not in Guest and Tor windows

[GeetaSarvadnya]

Verification passed on

Brave	0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision	201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from App Menu gets Create Profile and Switch to Guest Profile items brave-core#3096
• Verified that click on Create a New Profile from the settings menu launches brave://welcome onboarding flow with a new profile
• Verified that Create New Profile item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Guest Window item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Open Guest Window opens the guest window
• Verified that Create New Profile and Open Guest Window items are in the disabled mode in Guest and Tor windows

Verification passed on

Brave	0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision	201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS	Ubuntu 18.04 LTS

• Verified the test plan from App Menu gets Create Profile and Switch to Guest Profile items brave-core#3096
• Verified that click on Create a New Profile from the settings menu launches brave://welcome onboarding flow with a new profile
• Verified that Create New Profile item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Guest Window item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Open Guest Window opens the guest window
• Verified that Create New Profile and Open Guest Window items are in the disabled mode in Guest and Tor windows

Verified passed with

Brave	0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified the test plan from App Menu gets Create Profile and Switch to Guest Profile items brave-core#3096
• Verified that click on Create a New Profile from the settings menu launches brave://welcome onboarding flow with a new profile
• Verified that Create New Profile item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Guest Window item available only in Normal and Private/Incognito windows Not in Guest and Tor windows
• Verified that Open Guest Window opens the guest window
• Verified that Create New Profile and Open Guest Window items are in the disabled mode in Guest and Tor windows