Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BackupResultsService in Web Discovery native double fetcher #27368

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#39439
Resolves brave/brave-browser#43399

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested a review from iefremov January 28, 2025 04:28
@DJAndries DJAndries force-pushed the wdp-native-double-fetch-fix branch from 48f790b to 523564f Compare January 28, 2025 05:12
@DJAndries DJAndries force-pushed the wdp-native-double-fetch-fix branch from 523564f to 5a4fe1b Compare January 28, 2025 17:33
Base automatically changed from wdp-native-reporting to master January 28, 2025 20:24
@DJAndries DJAndries force-pushed the wdp-native-double-fetch-fix branch from 5a4fe1b to 6f13dc8 Compare January 28, 2025 21:03
@DJAndries DJAndries enabled auto-merge January 29, 2025 01:08
@DJAndries DJAndries merged commit 706d863 into master Jan 29, 2025
18 checks passed
@DJAndries DJAndries deleted the wdp-native-double-fetch-fix branch January 29, 2025 02:06
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 29, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hidden renderer for fetching backup search results Native re-implementation of Web Discovery (part 1)
5 participants