Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wallet public_key to private_key and remove logging of private key #2656

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 11, 2019

Fixes brave/brave-browser#4796

Submitter Checklist:

Test Plan:

  • Confirm an Ad and that confirmations are redeemed
  • Confirm private key is not logged to the console (Search for SetWalletInfo:)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey changed the title Refactor wallet public_key to private_key and remove logging Refactor wallet public_key to private_key and remove logging of private key Jun 11, 2019
@fmarier
Copy link
Member

fmarier commented Jun 11, 2019

If #2609 gets uplifted, I would recommend uplifting this one too in order to eliminate the risk of users pasting their console log into an issue / support request / forum post and then getting their grants wallets stolen.

@tmancey tmancey merged commit 2fb32d7 into master Jun 11, 2019
@tmancey tmancey deleted the issues/4796 branch June 11, 2019 23:03
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
temporarily disable brave ads on linux
hashmi-waseem pushed a commit to hashmi-waseem/brave-core that referenced this pull request May 6, 2024
temporarily disable brave ads on linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor wallet public_key to private_key and remove logging of private key to console
3 participants