Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor wallet public_key to private_key and remove logging of private key to console #4796

Closed
tmancey opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2656
Closed

Refactor wallet public_key to private_key and remove logging of private key to console #4796

tmancey opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2656
Assignees
@tmancey
Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Milestone
0.66.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 11, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#2656

Description

Refactor Confirmations wallet public_key to private_key and remove logging of private key to console
@tmancey tmancey self-assigned this Jun 11, 2019
@tmancey tmancey added this to the 0.68.x - Nightly milestone Jun 11, 2019
@tmancey tmancey mentioned this issue Jun 11, 2019
Merged
28 tasks
@tmancey tmancey added QA/No security priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 11, 2019
@tmancey tmancey changed the title Refactor wallet public_key to private_key and remove logging Refactor wallet public_key to private_key and remove logging of private key to console Jun 11, 2019
@tmancey tmancey added QA/Yes priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed QA/No priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 11, 2019
tmancey added a commit to brave/brave-core that referenced this issue Jun 11, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
2fb32d7 
Fixes brave/brave-browser#4796
tmancey added a commit to brave/brave-core that referenced this issue Jun 12, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
0eaecd3 
Fixes brave/brave-browser#4796
tmancey added a commit to brave/brave-core that referenced this issue Jun 19, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
0572ba8 
Fixes brave/brave-browser#4796
tmancey added a commit to brave/brave-core that referenced this issue Jun 19, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
8e6a1cc 
Fixes brave/brave-browser#4796
This was referenced Jun 19, 2019
Merged
Merged
tmancey added a commit to brave/brave-core that referenced this issue Jun 25, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
516d0f8 
Fixes brave/brave-browser#4796
tmancey added a commit to brave/brave-core that referenced this issue Jun 25, 2019
@tmancey
Refactor wallet public_key to private_key and remove logging
6303d0d 
Fixes brave/brave-browser#4796
This was referenced Jun 27, 2019
Closed
Closed
Closed
@srirambv
Copy link
Contributor

srirambv commented Jun 28, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux
  • Verified ads viewed and confirmations are redeemed
  • Verified private key is masked in logs
    image

Verification passed on

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified tokens redeemed at server side for viewed ads - successfully paid message is verified in logs
  • Verified Private Key is in encrypted form in logs
  • Verified Public key is removed from logs

image

Verified passed with

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude security
Projects
None yet
Milestone
0.66.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Refactor wallet public_key to private_key and remove logging of private key brave/brave-core
5 participants
@tmancey @bsclifton @srirambv @LaurenWags @GeetaSarvadnya