Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced NOTREACHED_IN_MIGRATION for Brave Sync code #26391

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves brave/brave-browser#42123

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

@AlexeyBarabash AlexeyBarabash self-assigned this Nov 6, 2024
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner November 6, 2024 16:04
@tmancey tmancey self-requested a review November 6, 2024 17:09
@AlexeyBarabash AlexeyBarabash force-pushed the brave_sync_fix_notreached_in_migration branch from e939ff4 to 2e7f6d7 Compare November 6, 2024 18:11
@AlexeyBarabash AlexeyBarabash merged commit c4d5ad3 into master Nov 7, 2024
17 checks passed
@AlexeyBarabash AlexeyBarabash deleted the brave_sync_fix_notreached_in_migration branch November 7, 2024 11:21
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 7, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace NOTREACHED_IN_MIGRATION at brave-sync code
5 participants