Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes call to ShouldBlockPlaylistWebUI(). #26378

Merged

Conversation

szilardszaloki
Copy link
Collaborator

@szilardszaloki szilardszaloki commented Nov 5, 2024

Resolves brave/brave-browser#42096.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@szilardszaloki szilardszaloki force-pushed the szilard/42096-fixes-call-to-ShouldBlockPlaylistWebUI branch 2 times, most recently from f198431 to 3d89359 Compare November 6, 2024 02:26
@szilardszaloki szilardszaloki force-pushed the szilard/42096-fixes-call-to-ShouldBlockPlaylistWebUI branch 2 times, most recently from 82c0899 to d21ca74 Compare November 6, 2024 20:00
@szilardszaloki szilardszaloki force-pushed the szilard/42096-fixes-call-to-ShouldBlockPlaylistWebUI branch from d21ca74 to 0ae54ec Compare November 6, 2024 20:56
@szilardszaloki szilardszaloki merged commit 7c88355 into master Nov 6, 2024
17 checks passed
@szilardszaloki szilardszaloki deleted the szilard/42096-fixes-call-to-ShouldBlockPlaylistWebUI branch November 6, 2024 22:39
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 6, 2024
brave-builds added a commit that referenced this pull request Nov 6, 2024
brave-builds added a commit that referenced this pull request Nov 6, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.1

kjozwiak pushed a commit that referenced this pull request Nov 7, 2024
kjozwiak pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DumpWithoutCrashing in playlist::PlaylistServiceFactory::GetInstance
3 participants